On Thu, Jul 06, 2000 at 11:55:14AM -0700, Skip Montanaro wrote:
>...
> + /* Exported function to load a readline history file */
> +
> + static PyObject *
> + read_history_file(self, args)
> + PyObject *self;
> + PyObject *args;
> + {
> + char *s = NULL;
> + if (!PyArg_ParseTuple(args, "|z:read_history_file", &s))
This allows somebody to pass read_history_file(None). That doesn't feel
right. I'd suggest using the 's' format code.
(if they want the default, then pass nothing at all)
>...
> + static PyObject *
> + write_history_file(self, args)
> + PyObject *self;
> + PyObject *args;
> + {
> + char *s = NULL;
> + if (!PyArg_ParseTuple(args, "|z:write_history_file", &s))
> + return NULL;
Same here.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4