Hi, yes, this was a problem on our side - fixing it just now, those were newly added packages and I forget to add them to packages to be rebranded. Miran On 04/20/2013 09:18 AM, Alan Bateman wrote: > On 20/04/2013 00:04, David Katleman wrote: >> Below are corrections to GPL headers found in JDK8 b86: >> >> http://cr.openjdk.java.net/~katleman/8012643/webrev.jaxws.01 >> http://cr.openjdk.java.net/~katleman/8012643/webrev.jdk.01 >> >> Corresponding CR >> >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012643 >> >> The jdk headers are punctuation changes. >> >> jaxws integrated 51 files with a wrong GPL header, so that part is a >> bit more involved. >> Still no code changes, just headers, so anyone is qualified to review >> them. > Looks fine to me too. > > I sponsored the JAX-WS update that went into b86. It was a monster > patch (>70000 lines of changes) and really hard to see the wood from > the trees when bringing in this volume of changes. In this case, the > 51 files had to have their package changed from upstream so I'll bet > this is why their headers were missed. > > Going forward, are fixing up issues in master a problem? Which scripts > should be run to catch issues like this? I see in the top level repo > that we have lic_check.sh - is that the script you use? Do you want > these issues caught by integrators before they are pushed to master? > > -Alan.
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4