RetroSearch Browse

Fri Apr 12 09:55:03 PDT 2013 · http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-April/002314.html

Hi, Dave.

They all look fine to me.  

I looked at all of them looking for common errors.  I was pleasantly surprised that none of these involve huge numbers of files.  (A missing ',' after the copyright year is obviously the biggest problem.)  Nice catch.

Thanks,
iris

-----Original Message-----
From: David Katleman 
Sent: Friday, April 12, 2013 9:07 AM
To: jdk8-dev
Subject: Review request: JDK8 b85 source with GPL header errors

Below are corrections to GPL headers found in JDK8 b85:

     http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/
     http://cr.openjdk.java.net/~katleman/8012048/webrev.jdk.01/
     http://cr.openjdk.java.net/~katleman/8012048/webrev.langtools.01/
     http://cr.openjdk.java.net/~katleman/8012048/webrev.nashorn.01/
     http://cr.openjdk.java.net/~katleman/8012048/webrev.root.01/

Most are simple punctuation changes.

As a veteran of many such header reviews, reviewing the patch link at the top of the webrev is often easier than each individual file.

     Thanks
	Dave

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-April/002314.html below:

Review request: JDK8 b85 source with GPL header errors