Enforce return
statements in callbacks of array methods
Some problems reported by this rule are manually fixable by editor suggestions
Table of ContentsArray
has several methods for filtering, mapping, and folding. If we forget to write return
statement in a callback of those, it’s probably a mistake. If you don’t want to use a return or don’t need the returned results, consider using .forEach instead.
Rule Detailsconst indexMap = myArray.reduce(function(memo, item, index) { memo[item] = index; }, {});
1
2
3
4
This rule enforces usage of return
statement in callbacks of array’s methods. Additionally, it may also enforce the forEach
array method callback to not return a value by using the checkForEach
option.
This rule finds callback functions of the following methods, then checks usage of return
statement.
Array.from
Array.prototype.every
Array.prototype.filter
Array.prototype.find
Array.prototype.findIndex
Array.prototype.findLast
Array.prototype.findLastIndex
Array.prototype.flatMap
Array.prototype.forEach
(optional, based on checkForEach
parameter)Array.prototype.map
Array.prototype.reduce
Array.prototype.reduceRight
Array.prototype.some
Array.prototype.sort
Array.prototype.toSorted
Examples of incorrect code for this rule:
Open in Playgroundconst indexMap = myArray.reduce(function(memo, item, index) { memo[item] = index; }, {}); const foo = Array.from(nodes, function(node) { if (node.tagName === "DIV") { return true; } }); const bar = foo.filter(function(x) { if (x) { return true; } else { return; } });
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
Examples of correct code for this rule:
Open in PlaygroundOptionsconst indexMap = myArray.reduce(function(memo, item, index) { memo[item] = index; return memo; }, {}); const foo = Array.from(nodes, function(node) { if (node.tagName === "DIV") { return true; } return false; }); const bar = foo.map(node => node.getAttribute("id"));
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
This rule accepts a configuration object with three options:
"allowImplicit": false
(default) When set to true
, allows callbacks of methods that require a return value to implicitly return undefined
with a return
statement containing no expression."checkForEach": false
(default) When set to true
, rule will also report forEach
callbacks that return a value."allowVoid": false
(default) When set to true
, allows void
in forEach
callbacks, so rule will not report the return value with a void
operator.Note: { "allowVoid": true }
works only if checkForEach
option is set to true
.
Examples of correct code for the { "allowImplicit": true }
option:
checkForEachconst undefAllTheThings = myArray.map(function(item) { return; });
1
2
3
4
Examples of incorrect code for the { "checkForEach": true }
option:
myArray.forEach(function(item) { return handleItem(item); }); myArray.forEach(function(item) { if (item < 0) { return x; } handleItem(item); }); myArray.forEach(function(item) { if (item < 0) { return void x; } handleItem(item); }); myArray.forEach(item => handleItem(item)); myArray.forEach(item => void handleItem(item)); myArray.forEach(item => { return handleItem(item); }); myArray.forEach(item => { return void handleItem(item); });
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
Examples of correct code for the { "checkForEach": true }
option:
allowVoidmyArray.forEach(function(item) { handleItem(item) }); myArray.forEach(function(item) { if (item < 0) { return; } handleItem(item); }); myArray.forEach(function(item) { handleItem(item); return; }); myArray.forEach(item => { handleItem(item); });
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
Examples of correct code for the { "allowVoid": true }
option:
Known LimitationsmyArray.forEach(item => void handleItem(item)); myArray.forEach(item => { return void handleItem(item); }); myArray.forEach(item => { if (item < 0) { return void x; } handleItem(item); });
1
2
3
4
5
6
7
8
9
10
11
12
13
14
This rule checks callback functions of methods with the given names, even if the object which has the method is not an array.
When Not To Use ItIf you don’t want to warn about usage of return
statement in callbacks of array’s methods, then it’s safe to disable this rule.
This rule was introduced in ESLint v2.0.0-alpha-1.
ResourcesRetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4